mahara-contributors team mailing list archive

[Robert Lyon <robertl@xxxxxxxxxxxxxxx>]

Public bug reported:

When I make a new page and click on the layout tab and then click save
the system throws errors. This is due to no layout option being selected
by default.

If I selected 'advanced' or 'basic' sections then the 3 column layout
get selected - but this is done in a less than optimal way as the value
for the layout is hardcoded in the js so it is expecting that the layout
option for the 3 column layout will have the id = 5, but this might not
always be the case. We really need to find the default layout with php
and pass the id to the js.

Also in th js code there are js variables like $selected, which are
written like they want to get the value from php.

It would be better for the variables:
- set by js to be written as 'var myvar ='
- set by jquery/mochikit to be written as '$()' or '$j()' (where appropriate)
- and have the php only be used on the right hand side of the sentance eg have 'var myvar = $phpvar'

** Affects: mahara
     Importance: High
         Status: Confirmed


** Tags: regression

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1307760

Title:
  Problems saving view layout - no option selected by default

Status in Mahara ePortfolio:
  Confirmed

Bug description:
  When I make a new page and click on the layout tab and then click save
  the system throws errors. This is due to no layout option being
  selected by default.

  If I selected 'advanced' or 'basic' sections then the 3 column layout
  get selected - but this is done in a less than optimal way as the
  value for the layout is hardcoded in the js so it is expecting that
  the layout option for the 3 column layout will have the id = 5, but
  this might not always be the case. We really need to find the default
  layout with php and pass the id to the js.

  Also in th js code there are js variables like $selected, which are
  written like they want to get the value from php.

  It would be better for the variables:
  - set by js to be written as 'var myvar ='
  - set by jquery/mochikit to be written as '$()' or '$j()' (where appropriate)
  - and have the php only be used on the right hand side of the sentance eg have 'var myvar = $phpvar'

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1307760/+subscriptions