← Back to team overview

mahara-contributors team mailing list archive

[Bug 1328310] Re: Let /local theme files override core theme files

 

Just some clarification for posterity.

There are two patches on this bug. The first one does specifically what
the bug header describes. It makes sure that the /local templates come
before any of the theme templates in the include list. There is a catch
to this, though. It turns out that /local was not actually last. It was
just below the current theme. So the include path was:

- current theme
- /local
- parent theme(s)

This patch changes it to the more logical:

- /local
- current theme
- parent theme

The second patch is a slight departure from the wording of this bug. It
allows for a /local/theme/static directory, which can provide and
override static assets (i.e. images and CSS files).

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1328310

Title:
  Let /local theme files override core theme files

Status in Mahara ePortfolio:
  In Progress

Bug description:
  When I discovered that you can put template files under
  /local/theme/templates, I assumed that they would act like lang files
  placed under /local, and override any other theme files.

  But it turns out that, no, they come further down in the include list
  than the theme directories, which means their only use is if you're
  creating entirely new content.

  I think that the ability to use /local to override an individual theme
  file would be quite useful, though.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1328310/+subscriptions


References