mahara-contributors team mailing list archive

[Mahara Bot <1323911@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/3391
Committed: http://gitorious.org/mahara/mahara/commit/b1ee27e05481cc2dd9554d125b082c556289719d
Submitter: Yuliya Bozhko (yuliya.bozhko@xxxxxxxxx)
Branch:    master

commit b1ee27e05481cc2dd9554d125b082c556289719d
Author: Aaron Wells <aaronw@xxxxxxxxxxxxxxx>
Date:   Wed May 28 14:46:29 2014 +1200

Adjust auth_get_auth_instances_for_wwwroot() to handle the new
institution.id column

Bug 1323911: Now that the auth_instance table and the institution table both have a
column called "id", the SQL query is ambiguous about which one it will return.
Cutting the query down so that it only returns the fields actually used in the code
resolves this ambiguity.

Change-Id: I5242aa7bdee38af9aa0a7da308bb0d30dc700621
Signed-off-by: Yuliya Bozhko <yuliya.bozhko@xxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1323911

Title:
  institution.id column breaks "auth_get_auth_instances_for_wwwroot()"
  function

Status in Mahara ePortfolio:
  In Progress

Bug description:
  The function (which is used during Mnet login) has a SQL query that
  selects "auth_instance.*, institution.*". It used to be that
  auth_instance had a column called "id" and institution did not, so
  this didn't cause any problems. But now that institution also has an
  "id" column, it overwrites the auth_instance.id in the PHP result set.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1323911/+subscriptions