mahara-contributors team mailing list archive

[Mahara Bot <1380829@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/3788
Committed: http://gitorious.org/mahara/mahara/commit/47ee961e8245158339e65c3442bbc50f3b875f82
Submitter: Son Nguyen (son.nguyen@xxxxxxxxxxxxxxx)
Branch:    master

commit 47ee961e8245158339e65c3442bbc50f3b875f82
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Mon Oct 13 08:55:51 2014 +1300

Making sure core message notifications are correct on upgrade

Bug 1380200 - make sure main two do not have 'none' option
Bug 1380829 - make sure the previous default email method is respected

On upgrade from 1.9 the default core notifications 'System message'
and 'Message from other users' can be set to 'none' - which is not
allowed.

This patch will fix that problem by making sure the default core
notifications are set to email and that any users are also updated to
beusing the newly set default method.

Also deals with setting the default email method correctly - the prev
change to notifications didn't set the default email method with the
correct currently being used method.

Change-Id: I98dcc8374876e20cb5c2952121b69dab99c7cf19
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1380829

Title:
  Default notification setting not kept from Mahara 1.9 to 1.10

Status in Mahara ePortfolio:
  Confirmed

Bug description:
  1.10RC1

  When you upgrade a pre 1.10 site to 1.10, the default notification
  types are all set to "Email" even though you might have set them to
  something else in the previously one line setting "Default
  notification method" in Site options -> Email settings.

  I think this needs to be fixed because site admins expect that the
  default notification method stays to what they have set it. They can
  be more granular in Mahara 1.10, but their previous default should
  make it over.

  To test:

  1. On Mahara 1.9 change the "Default notification method" to "Email digest" in Admin -> Config site -> Site options -> Email settings.
  2. Create a user and check that the notification settings for all notification types are set to "Email digest".
  3. Change one of the notification types to "Inbox" and one to "Email".
  4. Upgrade the site and check that Admin -> Config site -> Site options -> Notification settings are all set to "Email digest".
  5. Create a new user and log in as that user to check that all notification types are set to "Email digest".
  6. Log in as the user created in step 2 and check that all notification types are still set to what that user had before the upgrade.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1380829/+subscriptions