mahara-contributors team mailing list archive

[Mahara Bot <1380200@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/3788
Committed: http://gitorious.org/mahara/mahara/commit/47ee961e8245158339e65c3442bbc50f3b875f82
Submitter: Son Nguyen (son.nguyen@xxxxxxxxxxxxxxx)
Branch:    master

commit 47ee961e8245158339e65c3442bbc50f3b875f82
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Mon Oct 13 08:55:51 2014 +1300

Making sure core message notifications are correct on upgrade

Bug 1380200 - make sure main two do not have 'none' option
Bug 1380829 - make sure the previous default email method is respected

On upgrade from 1.9 the default core notifications 'System message'
and 'Message from other users' can be set to 'none' - which is not
allowed.

This patch will fix that problem by making sure the default core
notifications are set to email and that any users are also updated to
beusing the newly set default method.

Also deals with setting the default email method correctly - the prev
change to notifications didn't set the default email method with the
correct currently being used method.

Change-Id: I98dcc8374876e20cb5c2952121b69dab99c7cf19
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1380200

Title:
  "System messages" and "Messages from other users" can be set to "None"

Status in Mahara ePortfolio:
  In Progress
Status in Mahara 1.10 series:
  In Progress
Status in Mahara 1.11 series:
  In Progress

Bug description:
  1.10RC1 (new feature in 1.10)

  The report at bug #1299993 says that system messages and messages from
  other users should not be able to be set to "None" and Steven
  confirmed that in his testing. However, when I look at it for the user
  manual, I can set those two notification types to "None" in both the
  "Notification settings (Config site -> Site options) and also under
  Settings -> Notifications.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1380200/+subscriptions