mahara-contributors team mailing list archive

[Robert Lyon <robertl@xxxxxxxxxxxxxxx>]

Public bug reported:

If I add some custom CSS to a skin that has badly formed css it doesn't
strip out the bad lines.

eg:

#footer {
 color: #deface;
 top:cat;
 width: 300px;
 odd:fellow;
}

It used to strip it down to leave the valid lines.

eg:

#footer {
 color: #deface;
 width: 300px;
}

This looks to have been broken with this patch
https://reviews.mahara.org/#/c/3846/

Well not broken as such but the  $preserve_css should be able to be set
via either the site config or directly in the config.php file so that
only sites that want to allow things like comments in the css can turn
it on rather than it be on by default for the skins.

It still strips out html tags - so that is good

** Affects: mahara
     Importance: High
         Status: Confirmed


** Tags: regression

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1384467

Title:
  CSS is not stripping out bad css attributes anymore

Status in Mahara ePortfolio:
  Confirmed

Bug description:
  If I add some custom CSS to a skin that has badly formed css it
  doesn't strip out the bad lines.

  eg:

  #footer {
   color: #deface;
   top:cat;
   width: 300px;
   odd:fellow;
  }

  It used to strip it down to leave the valid lines.

  eg:

  #footer {
   color: #deface;
   width: 300px;
  }

  This looks to have been broken with this patch
  https://reviews.mahara.org/#/c/3846/

  Well not broken as such but the  $preserve_css should be able to be
  set via either the site config or directly in the config.php file so
  that only sites that want to allow things like comments in the css can
  turn it on rather than it be on by default for the skins.

  It still strips out html tags - so that is good

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1384467/+subscriptions