mahara-contributors team mailing list archive

[Mahara Bot <1384529@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/3861
Committed: http://gitorious.org/mahara/mahara/commit/a63eb645ce6072420c42ad8ebdcbeb78b7360acf
Submitter: Aaron Wells (aaronw@xxxxxxxxxxxxxxx)
Branch:    master

commit a63eb645ce6072420c42ad8ebdcbeb78b7360acf
Author: Yuliya Bozhko <yuliya.bozhko@xxxxxxxxxxxxx>
Date:   Thu Oct 23 16:00:19 2014 +1300

Fix for comments pagination with showcomment option (Bug #1384529)

Change-Id: If5991307ca8065c48f1309bcfc37f62df0dd12a5
Signed-off-by: Yuliya Bozhko <yuliya.bozhko@xxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1384529

Title:
  Comments pagination is off by one

Status in Mahara ePortfolio:
  Fix Committed
Status in Mahara 1.10 series:
  Fix Committed
Status in Mahara 1.11 series:
  Fix Committed
Status in Mahara 1.8 series:
  Fix Committed
Status in Mahara 1.9 series:
  Fix Committed

Bug description:
  When you view a page, if you pass showcomment=$commentid, it should
  set pagination to display the page of comments containing $commentid.

  There seems to be an off by one error as at the boundaries it doesn't
  quite work.

  If you try to show the first comment on a new page, it actually shows
  the previous page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1384529/+subscriptions