← Back to team overview

mahara-contributors team mailing list archive

[Bug 1384529] Re: Comments pagination is off by one

 

** Also affects: mahara/1.11
   Importance: Low
     Assignee: Yuliya Bozhko (yuliya.bozhko)
       Status: Fix Committed

** Also affects: mahara/1.9
   Importance: Undecided
       Status: New

** Also affects: mahara/1.10
   Importance: Undecided
       Status: New

** Also affects: mahara/1.8
   Importance: Undecided
       Status: New

** Changed in: mahara/1.10
    Milestone: None => 1.10.1

** Changed in: mahara/1.10
       Status: New => Fix Committed

** Changed in: mahara/1.10
   Importance: Undecided => Low

** Changed in: mahara/1.8
       Status: New => Fix Committed

** Changed in: mahara/1.8
   Importance: Undecided => Low

** Changed in: mahara/1.11
    Milestone: None => 1.11.0

** Changed in: mahara/1.8
    Milestone: None => 1.8.6

** Changed in: mahara/1.9
       Status: New => Fix Committed

** Changed in: mahara/1.9
   Importance: Undecided => Low

** Changed in: mahara/1.9
    Milestone: None => 1.9.4

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1384529

Title:
  Comments pagination is off by one

Status in Mahara ePortfolio:
  Fix Committed
Status in Mahara 1.10 series:
  Fix Committed
Status in Mahara 1.11 series:
  Fix Committed
Status in Mahara 1.8 series:
  Fix Committed
Status in Mahara 1.9 series:
  Fix Committed

Bug description:
  When you view a page, if you pass showcomment=$commentid, it should
  set pagination to display the page of comments containing $commentid.

  There seems to be an off by one error as at the boundaries it doesn't
  quite work.

  If you try to show the first comment on a new page, it actually shows
  the previous page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1384529/+subscriptions


References