mahara-contributors team mailing list archive

[Aaron Wells <1386970@xxxxxxxxxxxxxxxxxx>]

Never mind, it turns out the alt tag is fine! It's just the Firefox Web
Developer tools display " as " when you're using the source inspect
tool.

But when I do "view source" outside of the web developer tools, I do see
".

However, that button is still missing a title tag.

** Summary changed:

- Broken alt tag (and missing title tag) on file unzip, edit, delete buttons
+ Missing title tag on file unzip button

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1386970

Title:
  Missing title tag on file unzip button

Status in Mahara ePortfolio:
  In Progress
Status in Mahara 1.10 series:
  Confirmed
Status in Mahara 1.9 series:
  Confirmed
Status in Mahara 15.04 series:
  In Progress

Bug description:
  The alt text for the "unzip", "edit", and "delete" buttons in the
  Content -> Files are, contains unescaped double quotes.

  <img alt="Decompress "3077-1316797096-PVE.zip"" src="http://vegas.wgtn
  .cat-it.co.nz/mahara/htdocs/theme/raw/static/images/btn_extract.png">

  These should be escaped into HTML entities (by being passed through
  htmlspecialchars()/hsc())

  <img alt="Decompress &quot;3077-1316797096-PVE.zip&quot;"
  src="http://vegas.wgtn.cat-
  it.co.nz/mahara/htdocs/theme/raw/static/images/btn_extract.png">

  This breaks the alt tag, and it also causes problems for our Behat
  testers because without the alt tag there's no way to uniquely
  identify one of these.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1386970/+subscriptions