mahara-contributors team mailing list archive

[Aaron Wells <1386970@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

The alt text for the "unzip", "edit", and "delete" buttons in the
Content -> Files are, contains unescaped double quotes.

<img alt="Decompress "3077-1316797096-PVE.zip"" src="http://vegas.wgtn
.cat-it.co.nz/mahara/htdocs/theme/raw/static/images/btn_extract.png">

These should be escaped into HTML entities (by being passed through
htmlspecialchars()/hsc())

<img alt="Decompress &quot;3077-1316797096-PVE.zip&quot;"
src="http://vegas.wgtn.cat-
it.co.nz/mahara/htdocs/theme/raw/static/images/btn_extract.png">

This breaks the alt tag, and it also causes problems for our Behat
testers because without the alt tag there's no way to uniquely identify
one of these.

** Affects: mahara
     Importance: Medium
     Assignee: Aaron Wells (u-aaronw)
         Status: In Progress

** Affects: mahara/1.10
     Importance: Medium
     Assignee: Aaron Wells (u-aaronw)
         Status: Confirmed

** Affects: mahara/1.9
     Importance: Medium
     Assignee: Aaron Wells (u-aaronw)
         Status: Confirmed

** Affects: mahara/15.04
     Importance: Medium
     Assignee: Aaron Wells (u-aaronw)
         Status: In Progress

** Also affects: mahara/1.10
   Importance: Undecided
       Status: New

** Also affects: mahara/1.9
   Importance: Undecided
       Status: New

** Also affects: mahara/15.04
   Importance: Medium
       Status: In Progress

** Changed in: mahara/1.10
   Importance: Undecided => Medium

** Changed in: mahara/1.9
   Importance: Undecided => Medium

** Changed in: mahara/1.9
    Milestone: None => 1.9.4

** Changed in: mahara/1.10
    Milestone: None => 1.10.1

** Changed in: mahara/1.10
       Status: New => Confirmed

** Changed in: mahara/1.9
       Status: New => Confirmed

** Changed in: mahara/15.04
     Assignee: (unassigned) => Aaron Wells (u-aaronw)

** Changed in: mahara/1.9
     Assignee: (unassigned) => Aaron Wells (u-aaronw)

** Changed in: mahara/1.10
     Assignee: (unassigned) => Aaron Wells (u-aaronw)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1386970

Title:
  Broken alt tag (and missing title tag) on file unzip, edit, delete
  buttons

Status in Mahara ePortfolio:
  In Progress
Status in Mahara 1.10 series:
  Confirmed
Status in Mahara 1.9 series:
  Confirmed
Status in Mahara 15.04 series:
  In Progress

Bug description:
  The alt text for the "unzip", "edit", and "delete" buttons in the
  Content -> Files are, contains unescaped double quotes.

  <img alt="Decompress "3077-1316797096-PVE.zip"" src="http://vegas.wgtn
  .cat-it.co.nz/mahara/htdocs/theme/raw/static/images/btn_extract.png">

  These should be escaped into HTML entities (by being passed through
  htmlspecialchars()/hsc())

  <img alt="Decompress &quot;3077-1316797096-PVE.zip&quot;"
  src="http://vegas.wgtn.cat-
  it.co.nz/mahara/htdocs/theme/raw/static/images/btn_extract.png">

  This breaks the alt tag, and it also causes problems for our Behat
  testers because without the alt tag there's no way to uniquely
  identify one of these.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1386970/+subscriptions