mahara-contributors team mailing list archive

[Mahara Bot <1386970@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/3879
Committed: http://gitorious.org/mahara/mahara/commit/e9cade24c148358c2e4772cc29317c1ba4dbe586
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    1.10_STABLE

commit e9cade24c148358c2e4772cc29317c1ba4dbe586
Author: Aaron Wells <aaronw@xxxxxxxxxxxxxxx>
Date:   Wed Oct 29 16:52:28 2014 +1300

Adding a title tag to the "unzip" button

Bug 1386970

Change-Id: Id2f5da4a4d1fabf77dbb73fc112d93ef353b6584

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1386970

Title:
  Missing title tag on file unzip button

Status in Mahara ePortfolio:
  Fix Committed
Status in Mahara 1.10 series:
  Fix Committed
Status in Mahara 1.9 series:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed

Bug description:
  The alt text for the "unzip", "edit", and "delete" buttons in the
  Content -> Files are, contains unescaped double quotes.

  <img alt="Decompress "3077-1316797096-PVE.zip"" src="http://vegas.wgtn
  .cat-it.co.nz/mahara/htdocs/theme/raw/static/images/btn_extract.png">

  These should be escaped into HTML entities (by being passed through
  htmlspecialchars()/hsc())

  <img alt="Decompress &quot;3077-1316797096-PVE.zip&quot;"
  src="http://vegas.wgtn.cat-
  it.co.nz/mahara/htdocs/theme/raw/static/images/btn_extract.png">

  This breaks the alt tag, and it also causes problems for our Behat
  testers because without the alt tag there's no way to uniquely
  identify one of these.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1386970/+subscriptions