mahara-contributors team mailing list archive

[Mahara Bot <1389906@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/3927
Committed: http://gitorious.org/mahara/mahara/commit/966b2776619020f6c97dfc3ba5b6e02a00c8c4a1
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    1.10_STABLE

commit 966b2776619020f6c97dfc3ba5b6e02a00c8c4a1
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Thu Nov 6 12:50:57 2014 +1300

Getting the accept friend to email requestor (Bug #1389906)

This was an oversight from the original commit
647c85495e87acedb3c7e6ac2cac82fcf4ea4d5c

Change-Id: Ie0d5e0306b2cf329574092387ac4c1a233ec2347
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1389906

Title:
  Accepting friend request does not send notification to requester

Status in Mahara ePortfolio:
  Fix Committed
Status in Mahara 1.10 series:
  Fix Committed
Status in Mahara 1.8 series:
  Fix Committed
Status in Mahara 1.9 series:
  Fix Committed

Bug description:
  In the file lib/user.php there are two functions acceptfriend_submit() and makefriend_submit() that were added by this commit:
  647c85495e87acedb3c7e6ac2cac82fcf4ea4d5c

  Both create a class of email message info called $n to send an email
  but only the makefriend_submit() actually sends the email.

  Will fix it so both send email, that way friend requester will get the
  'Friend request accepted' message.

  As this was a bug/oversight way back in 2008 and I'll mark as high and
  backport to the prev 3 versions as well.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1389906/+subscriptions