mahara-contributors team mailing list archive

[Robert Lyon <robertl@xxxxxxxxxxxxxxx>]

Public bug reported:

In the file lib/user.php there are two functions acceptfriend_submit() and makefriend_submit() that were added by this commit:
647c85495e87acedb3c7e6ac2cac82fcf4ea4d5c

Both create a class of email message info called $n to send an email but
only the makefriend_submit() actually sends the email.

Will fix it so both send email, that way friend requester will get the
'Friend request accepted' message.

As this was a bug/oversight way back in 2008 and I'll mark as high and
backport to the prev 3 versions as well.

** Affects: mahara
     Importance: High
     Assignee: Robert Lyon (robertl-9)
         Status: In Progress

** Affects: mahara/1.10
     Importance: High
     Assignee: Robert Lyon (robertl-9)
         Status: New

** Affects: mahara/1.8
     Importance: High
     Assignee: Robert Lyon (robertl-9)
         Status: New

** Affects: mahara/1.9
     Importance: High
     Assignee: Robert Lyon (robertl-9)
         Status: New

** Also affects: mahara/1.10
   Importance: Undecided
       Status: New

** Also affects: mahara/1.9
   Importance: Undecided
       Status: New

** Also affects: mahara/1.8
   Importance: Undecided
       Status: New

** Changed in: mahara/1.10
    Milestone: None => 1.10.1

** Changed in: mahara/1.8
    Milestone: None => 1.9.4

** Changed in: mahara/1.8
    Milestone: 1.9.4 => 1.8.6

** Changed in: mahara/1.9
    Milestone: None => 1.9.4

** Changed in: mahara/1.10
   Importance: Undecided => High

** Changed in: mahara/1.8
   Importance: Undecided => High

** Changed in: mahara/1.9
   Importance: Undecided => High

** Changed in: mahara/1.10
     Assignee: (unassigned) => Robert Lyon (robertl-9)

** Changed in: mahara/1.8
     Assignee: (unassigned) => Robert Lyon (robertl-9)

** Changed in: mahara/1.9
     Assignee: (unassigned) => Robert Lyon (robertl-9)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1389906

Title:
  Accepting friend request does not send notification to requester

Status in Mahara ePortfolio:
  In Progress
Status in Mahara 1.10 series:
  New
Status in Mahara 1.8 series:
  New
Status in Mahara 1.9 series:
  New

Bug description:
  In the file lib/user.php there are two functions acceptfriend_submit() and makefriend_submit() that were added by this commit:
  647c85495e87acedb3c7e6ac2cac82fcf4ea4d5c

  Both create a class of email message info called $n to send an email
  but only the makefriend_submit() actually sends the email.

  Will fix it so both send email, that way friend requester will get the
  'Friend request accepted' message.

  As this was a bug/oversight way back in 2008 and I'll mark as high and
  backport to the prev 3 versions as well.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1389906/+subscriptions