mahara-contributors team mailing list archive

[Mahara Bot <1394732@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/4025
Committed: http://gitorious.org/mahara/mahara/commit/d524a12ad28309007e8704c52418ae7b18def987
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    1.10_STABLE

commit d524a12ad28309007e8704c52418ae7b18def987
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Fri Nov 21 09:13:47 2014 +1300

Fixing type checking on min/max values (Bug #1394732)

Change-Id: I042c1127f7601483e8723b2e31bf07683accf2c0
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1394732

Title:
  pieform minvalue/maxvalue rule error

Status in Mahara ePortfolio:
  Fix Committed
Status in Mahara 1.10 series:
  Fix Committed
Status in Mahara 1.8 series:
  Fix Committed
Status in Mahara 1.9 series:
  Fix Committed

Bug description:
  Currently it does a check $value != ''

  It needs to check the type as '' will be the same as 0 in this case -
  which is not correct because 0 will not be seen as less than 1

  so it needs to be $value !== ''

  I'll mark this as high as the rule is a fundamental part of the
  pieforms system

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1394732/+subscriptions