mahara-contributors team mailing list archive

[Robert Lyon <robertl@xxxxxxxxxxxxxxx>]

Public bug reported:

Currently it does a check $value != ''

It needs to check the type as '' will be the same as 0 in this case -
which is not correct because 0 will not be seen as less than 1

so it needs to be $value !== ''

I'll mark this as high as the rule is a fundamental part of the pieforms
system

** Affects: mahara
     Importance: High
     Assignee: Robert Lyon (robertl-9)
         Status: In Progress

** Affects: mahara/1.10
     Importance: Undecided
         Status: New

** Affects: mahara/1.8
     Importance: Undecided
         Status: New

** Affects: mahara/1.9
     Importance: Undecided
         Status: New

** Changed in: mahara
    Milestone: None => 15.04.0

** Also affects: mahara/1.9
   Importance: Undecided
       Status: New

** Also affects: mahara/1.10
   Importance: Undecided
       Status: New

** Also affects: mahara/1.8
   Importance: Undecided
       Status: New

** Changed in: mahara/1.10
    Milestone: None => 1.10.1

** Changed in: mahara/1.8
    Milestone: None => 1.9.4

** Changed in: mahara/1.9
    Milestone: None => 1.8.6

** Changed in: mahara/1.8
    Milestone: 1.9.4 => 1.8.6

** Changed in: mahara/1.9
    Milestone: 1.8.6 => 1.9.4

** Summary changed:

- pieform minvalue rule error
+ pieform minvalue/maxvalue rule error

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1394732

Title:
  pieform minvalue/maxvalue rule error

Status in Mahara ePortfolio:
  In Progress
Status in Mahara 1.10 series:
  New
Status in Mahara 1.8 series:
  New
Status in Mahara 1.9 series:
  New

Bug description:
  Currently it does a check $value != ''

  It needs to check the type as '' will be the same as 0 in this case -
  which is not correct because 0 will not be seen as less than 1

  so it needs to be $value !== ''

  I'll mark this as high as the rule is a fundamental part of the
  pieforms system

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1394732/+subscriptions