mahara-contributors team mailing list archive

[Jinelle Foley-Barnes <jinelleb@xxxxxxxxxxxxxxx>]

Hi AaronW,


Here's a list of ways to get to the link/buttons that we discussed. You should be able to identify patterns in the data from this. The next lot I find I'll post up here also.  

(Mahara 15.04dev)

1. Content- > Profile -> Social media -> Create the social media
accounts. When they display "Edit" and "Delete" are links disguised as
buttons.

2.  Content -> Files -> Upload the files -> The "Edit" and "Delete"
buttons are links.

3.  Content -> Journal -> Add new entries -> The "Edit and "Delete"  I
think they're buttons and they look like buttons.

4. Content -> Resume -> Education and employment -> Add (Either
education history or employment histroy) ->  The "Edit" and "Delete"
buttons are links.

5.  Content -> Resume -> Achievement -> Add (Certifications, accreditations and awards, Books and publications, Professional memberships) ->  The "Edit" and "Delete" buttons are links.
 
6 .  Content -> Resume -> Goals and skills -> The "Edit 'name' goal" is a link disguised a button

7.  Content -> Plan ->  New plan -> All the buttons are links.

8.  Portfolio -> Pages ->  "Edit Content and layout" and "Delete this
page" buttons are links

9. Portfolio -> Collections -> Create new collections -> "Manage pages",
"Edit title and description" and "Delete collection" are all buttons are
links.

10.  Portfolio -> Collections -> Copy a collection -> The "Copy page"
buttons, are wrapped in <span></span> tags and not recgonised as a
button easily.

11.  Portfolio -> Collections -> The actual "New collection" button
itself is a link, but has the appearance of a button. Also it is in the
class "btn" which could be confusing.

12. Portfolio -> Collections -> The actual "Copy a collection" button
itself is a link, but has the appearance of a button. Also it is in the
class "btn" which could be confusing.

13.  Portfolio -> Shared by me -> Edit access butons and Secret URLs all
look like buttons but are links

14. Administration -> Configure site -> Licences ->  All the "Edit"
buttons are actually links and the "Delete" buttons are actually
buttons.

15. Administration -> Configure site -> Pages -> "Edit content and
layout" and "Delete" and both actually links but look like buttons.

16. Administration -> Configure site -> Collections -> Adding a
collection -> then the  "Done" is a link but disguised as a button. All
other buttons at the bottom of a fom are actually buttons. However this
is a link.

17. Just for comparison,  Administration -> Configure site -> Cookie
consent ->  "Save changes" is a button in table data and not a link.

18.  Administration -> Configure site -> File -> "Edit" and "Delete"
look like buttons and are buttons.

19.  Administation -> Users -> Site staff -> "Submit" button is a
button, not a link.

20.  Administration -> Institution -> Institution -> "Edit" is a button and is also displayed as a button.
 
21.  Administration ->  Extensions -> Allowed iframe sources -> "Edit" buttons are actually links and the "Delete" buttons are buttons. 

22.  On the Main page the Dashboard "Edit dashboard" button is actually
a link and not a buton as it appears.

Thanks, 
Jinelle

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1387412

Title:
  Eliminate links-that-look-like-buttons & buttons-that-look-like-links

Status in Mahara ePortfolio:
  Confirmed

Bug description:
  Mahara contains quite a few HTML links (<a> tags) that are styled to
  look like buttons. It may also contain some buttons (<input> tags and
  <button> tags) that are styled to look like links.

  These interfere with our ability to write automated tests, and they're
  bad for accessibility. As the Mahara accessibility checklist says:

  "Use buttons and links consistently.
  -  Use a link if you're navigating to a predefined page or section (navigation, tabs, etc.)
  -  Use a button if you're changing information or state (submitting a form, editing or deleting content, searching, etc.)"

  From
  https://wiki.mahara.org/index.php/Developer_Area/Accessibility_Checklist#Forms

  To facilitate this, we should write a PHP function (and Dwoo tag) that
  allows you to create a "link button", i.e. a button that, when
  clicked, simply takes you to a specified URL. Then we can
  systematically locate all the links-that-look-like-buttons and replace
  them with actual buttons using this functionality.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1387412/+subscriptions