← Back to team overview

mahara-contributors team mailing list archive

[Bug 1387412] [NEW] Eliminate links-that-look-like-buttons & buttons-that-look-like-links

 

Public bug reported:

Mahara contains quite a few HTML links (<a> tags) that are styled to
look like buttons. It may also contain some buttons (<input> tags and
<button> tags) that are styled to look like links.

These interfere with our ability to write automated tests, and they're
bad for accessibility. As the Mahara accessibility checklist says:

"Use buttons and links consistently.
-  Use a link if you're navigating to a predefined page or section (navigation, tabs, etc.)
-  Use a button if you're changing information or state (submitting a form, editing or deleting content, searching, etc.)"

From
https://wiki.mahara.org/index.php/Developer_Area/Accessibility_Checklist#Forms

To facilitate this, we should write a PHP function (and Dwoo tag) that
allows you to create a "link button", i.e. a button that, when clicked,
simply takes you to a specified URL. Then we can systematically locate
all the links-that-look-like-buttons and replace them with actual
buttons using this functionality.

** Affects: mahara
     Importance: Medium
     Assignee: Aaron Wells (u-aaronw)
         Status: Confirmed


** Tags: accessibility testing

** Changed in: mahara
   Importance: Undecided => Medium

** Changed in: mahara
       Status: New => Confirmed

** Changed in: mahara
     Assignee: (unassigned) => Aaron Wells (u-aaronw)

** Changed in: mahara
    Milestone: None => 15.04.0

** Tags removed: accessibilyt
** Tags added: accessibility

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1387412

Title:
  Eliminate links-that-look-like-buttons & buttons-that-look-like-links

Status in Mahara ePortfolio:
  Confirmed

Bug description:
  Mahara contains quite a few HTML links (<a> tags) that are styled to
  look like buttons. It may also contain some buttons (<input> tags and
  <button> tags) that are styled to look like links.

  These interfere with our ability to write automated tests, and they're
  bad for accessibility. As the Mahara accessibility checklist says:

  "Use buttons and links consistently.
  -  Use a link if you're navigating to a predefined page or section (navigation, tabs, etc.)
  -  Use a button if you're changing information or state (submitting a form, editing or deleting content, searching, etc.)"

  From
  https://wiki.mahara.org/index.php/Developer_Area/Accessibility_Checklist#Forms

  To facilitate this, we should write a PHP function (and Dwoo tag) that
  allows you to create a "link button", i.e. a button that, when
  clicked, simply takes you to a specified URL. Then we can
  systematically locate all the links-that-look-like-buttons and replace
  them with actual buttons using this functionality.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1387412/+subscriptions


Follow ups

References