mahara-contributors team mailing list archive

[Mahara Bot <1387858@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/4138
Committed: http://gitorious.org/mahara/mahara/commit/90b5f72052038a85372dd4851e8144ba8ab16622
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    1.10_STABLE

commit 90b5f72052038a85372dd4851e8144ba8ab16622
Author: Son Nguyen <son.nguyen@xxxxxxxxxxxxxxx>
Date:   Fri Jan 9 12:06:35 2015 +1300

Make sure draft post not visible. Bug 1387858

- Filter out draft posts when editing the blogpost block
- Don't display the post's content if it is unpublished

Change-Id: Iaaf92f29383e2f3997e214b052dd116005a971dd
Signed-off-by: Son Nguyen <son.nguyen@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1387858

Title:
  Draft journal entries are visible to others

Status in Mahara ePortfolio:
  Fix Committed
Status in Mahara 1.10 series:
  In Progress
Status in Mahara 1.8 series:
  Confirmed
Status in Mahara 1.9 series:
  Confirmed

Bug description:
  confirmed for master (15.04), 1.10, 1.9 and 1.8

  When a user creates a journal entry as draft and puts that into a
  page, it is also visible to other users when they have access to the
  page.

  When the user puts the entire journal into a page (or tagged journal
  entries), the draft entry is not visible because it is in draft
  status.

  There are two possibilities as far as I can see right now:

  1.
  Do not allow users to include journal entries that are in draft status into a page (and mention that in the block pop-up so they don't wonder why draft entries do not show up).

  2. 
  The block "Journal entry" needs to be changed so that draft entries are only visible to the author at most but not other users on the page. This should also include some visual indicator as we have in the journal itself for the draft. "Draft" could also be mentioned next to the title of the journal entry when selecting it in the block pop-up.

  I tend towards option 1 as that is cleaner and more in line with the
  behavior of the other blocks. We should then also mention on the other
  blocks that draft entries are not displayed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1387858/+subscriptions