mahara-contributors team mailing list archive

[Mahara Bot <946880@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/3507
Committed: http://gitorious.org/mahara/mahara/commit/1a83b282acb2696fcacd1c11c5d039eef0d7461e
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 1a83b282acb2696fcacd1c11c5d039eef0d7461e
Author: Nigel Cunningham <nigelc@xxxxxxxxxxxxxxx>
Date:   Thu Jul 24 10:02:09 2014 +1000

Fix form submission for no-reply email setting (Bug #946880)

After installation or upgrade, if the user clicks on a warning
about the no-reply email address and they also need to set up
required fields, the URL for the no-reply email address is
initially overridden by the required fields form. This patch
causes us to cleanly drop back out of the required fields form
code after the required fields form is successfully submitted,
letting the user then see the no-reply email address form.

This method of handling things will also work for any other
time the required fields form hijacks a URL - after the required
fields are set, the user will get the page they asked for.

Change-Id: I32aecaf898d02a572a5ab7b5c18bfaefc5607e41
Signed-off-by: Nigel Cunningham <nigelc@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/946880

Title:
  Broken html error message for no-reply email setting

Status in Mahara ePortfolio:
  Fix Committed
Status in Mahara 1.10 series:
  Fix Released
Status in Mahara 1.8 series:
  Fix Released
Status in Mahara 1.9 series:
  Fix Released
Status in Mahara 15.04 series:
  Fix Committed

Bug description:
  error message when upgrading from 1.4 to 1.5:

  The noreply address setting is either empty or has an invalid email
  address. Please check the configuration in the <a
  href="http://15stable/admin/site/options.php?fs=emailsettings";>site
  options in the email settings</a>.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/946880/+subscriptions