mahara-contributors team mailing list archive

[Mahara Bot <1431673@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/4404
Committed: http://gitorious.org/mahara/mahara/commit/cba61086e073537fff883ffda9637a490b826ede
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit cba61086e073537fff883ffda9637a490b826ede
Author: Aaron Wells <aaronw@xxxxxxxxxxxxxxx>
Date:   Fri Mar 13 18:29:37 2015 +1300

Hard-coded lang string in blocktype/annotation Javascript

Bug 1431673. In order to replace this with a proper lang string,
I had to change the annotation blocktype so that it's using
the proper APIs for its JS file.

Change-Id: I5155be2505f4986e424bf2909769377de7cd8c42

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1431673

Title:
  Hard-coded language string in artefact/annotation/js/annotation.js

Status in Mahara ePortfolio:
  Fix Committed

Bug description:
  I just noticed a hard-coded English language string in the artefact
  plugin's "annotation.js" file.

  In the function "ConnectAnnotationFeedbackLinks()", on line 248:

                                  var closer = $j('<a id="closer_' +
  blockid + '" href="#" class="close-link">Close</a>').click(function(e)
  {

  The word "Close" in the middle of that <a> tag needs to be replaced
  with a language string. See
  https://wiki.mahara.org/index.php/Developer_Area/Language_strings#How_to_use_lang_strings_from_Javascript
  for how to use a language string from Javascript.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1431673/+subscriptions