mahara-contributors team mailing list archive

[Aaron Wells <1431673@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

I just noticed a hard-coded English language string in the artefact
plugin's "annotation.js" file.

In the function "ConnectAnnotationFeedbackLinks()", on line 248:

                                var closer = $j('<a id="closer_' +
blockid + '" href="#" class="close-link">Close</a>').click(function(e) {

The word "Close" in the middle of that <a> tag needs to be replaced with
a language string. See
https://wiki.mahara.org/index.php/Developer_Area/Language_strings#How_to_use_lang_strings_from_Javascript
for how to use a language string from Javascript.

** Affects: mahara
     Importance: Medium
     Assignee: Ghada El-Zoghbi (ghada-z)
         Status: Confirmed


** Tags: annotations smartevidence

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1431673

Title:
  Hard-coded language string in artefact/annotation/js/annotation.js

Status in Mahara ePortfolio:
  Confirmed

Bug description:
  I just noticed a hard-coded English language string in the artefact
  plugin's "annotation.js" file.

  In the function "ConnectAnnotationFeedbackLinks()", on line 248:

                                  var closer = $j('<a id="closer_' +
  blockid + '" href="#" class="close-link">Close</a>').click(function(e)
  {

  The word "Close" in the middle of that <a> tag needs to be replaced
  with a language string. See
  https://wiki.mahara.org/index.php/Developer_Area/Language_strings#How_to_use_lang_strings_from_Javascript
  for how to use a language string from Javascript.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1431673/+subscriptions