mahara-contributors team mailing list archive

[Kristina Hoeppner <1435408@xxxxxxxxxxxxxxxxxx>]

Hello Eric,

Thank you for your report. We know of the problem and on occassion, on
large installations, have increased the limit to display more than 100
users, but also hard-coded. A similar report was made in bug #722432.

We will need to rethink the entire screen and others that are similar to
this two-window approach as it is not flexible enough. It doesn't allow
you to search for users comfortably. I imagine that a default choice of
being able to search only within your own institution's members and only
upon click searching for any user might solve some of the problems as it
would reduce the number of people dramatically on multi-tenanted sites,
but wouldn't really be of help to those on their own instance. Aaron was
proposing to use the select2 functionality, i.e. start typing a name and
it appears like for sending messages since Mahara 1.10. With that we
would still need a bulk option. Increasing the limit / making it
configurable could be an interim step, but eventually, we would need
something better.

If you want to, Eric, feel free to put your patch into our code review
system (how to:
https://wiki.mahara.org/index.php/Developer_Area/Contributing_Code ) or
let us know if you want one of the core developers to do that for this
patch. Since we may not be able to make a big leap in this area to re-
design the screen entirely for Mahara 15.10, your solution may be a good
interim one.

Cheers
Kristina

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1435408

Title:
  Add configs for hard coded settings

Status in Mahara ePortfolio:
  Confirmed

Bug description:
  When trying to bulk add group members, I can only see 100 of the
  potential members.

  The 'Add members' dialog says: 'Only showing first 100 results of
  148'.

  This is a hard code limit (see below) and there isn't any way to
  select the remaining potential members.

  Some fix options are
  1. Provide a config entry that allows increasing the lookup limit
  2. Add code to 'page' through the lookup list 100 members at a time
  3. You might simply filter by Institution to provide a way to limit the list of potential members

  Fix 2 and/or 3 could easily be accomplished by adapting code from
  /admin/users/search.php.

  
  My work around is in place - I just raised the limit to 200 and this will hold until the next upgrade.
  /group/addmembers.php line 48
    
  $form = pieform(array(
      'name' => 'addmembers',
      'elements' => array(
          'users' => array(
              'type' => 'userlist',
              'lefttitle' => get_string('potentialmembers', 'group'),
              'righttitle' => get_string('userstobeadded', 'group'),
              'searchscript' => 'group/membersearchresults.json.php',
              'defaultvalue' => array(),
              'searchparams' => array(
                  'id' => GROUP,
                  'limit' => 200,
                  'html' => 0,
                  'membershiptype' => 'nonmember',
              ),
          ),
          'submit' => array(
              'type' => 'submit',
              'value' => get_string('submit'),
          )
      )
  ));

  Also see:
  /admin/users/staff.php 'limit' => 250,
  /admin/users/admins.php 'limit' => 250,

  /group/inviteusers.php 'limit' => 100,
  /group/suggest.php 'limit' => 100,

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1435408/+subscriptions