← Back to team overview

mahara-contributors team mailing list archive

[Bug 1435408] [NEW] Add configs for hard coded settings

 

Public bug reported:

When trying to bulk add group members, I can only see 100 of the
potential members.

The 'Add members' dialog says: 'Only showing first 100 results of 148'.

This is a hard code limit (see below) and there isn't any way to select
the remaining potential members.

Some fix options are
1. Provide a config entry that allows increasing the lookup limit
2. Add code to 'page' through the lookup list 100 members at a time
3. You might simply filter by Institution to provide a way to limit the list of potential members

Fix 2 and/or 3 could easily be accomplished by adapting code from
/admin/users/search.php.


My work around is in place - I just raised the limit to 200 and this will hold until the next upgrade.
/group/addmembers.php line 48
  
$form = pieform(array(
    'name' => 'addmembers',
    'elements' => array(
        'users' => array(
            'type' => 'userlist',
            'lefttitle' => get_string('potentialmembers', 'group'),
            'righttitle' => get_string('userstobeadded', 'group'),
            'searchscript' => 'group/membersearchresults.json.php',
            'defaultvalue' => array(),
            'searchparams' => array(
                'id' => GROUP,
                'limit' => 200,
                'html' => 0,
                'membershiptype' => 'nonmember',
            ),
        ),
        'submit' => array(
            'type' => 'submit',
            'value' => get_string('submit'),
        )
    )
));

Also see:
/admin/users/staff.php 'limit' => 250,
/admin/users/admins.php 'limit' => 250,

/group/inviteusers.php 'limit' => 100,
/group/suggest.php 'limit' => 100,

** Affects: mahara
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1435408

Title:
  Add configs for hard coded settings

Status in Mahara ePortfolio:
  New

Bug description:
  When trying to bulk add group members, I can only see 100 of the
  potential members.

  The 'Add members' dialog says: 'Only showing first 100 results of
  148'.

  This is a hard code limit (see below) and there isn't any way to
  select the remaining potential members.

  Some fix options are
  1. Provide a config entry that allows increasing the lookup limit
  2. Add code to 'page' through the lookup list 100 members at a time
  3. You might simply filter by Institution to provide a way to limit the list of potential members

  Fix 2 and/or 3 could easily be accomplished by adapting code from
  /admin/users/search.php.

  
  My work around is in place - I just raised the limit to 200 and this will hold until the next upgrade.
  /group/addmembers.php line 48
    
  $form = pieform(array(
      'name' => 'addmembers',
      'elements' => array(
          'users' => array(
              'type' => 'userlist',
              'lefttitle' => get_string('potentialmembers', 'group'),
              'righttitle' => get_string('userstobeadded', 'group'),
              'searchscript' => 'group/membersearchresults.json.php',
              'defaultvalue' => array(),
              'searchparams' => array(
                  'id' => GROUP,
                  'limit' => 200,
                  'html' => 0,
                  'membershiptype' => 'nonmember',
              ),
          ),
          'submit' => array(
              'type' => 'submit',
              'value' => get_string('submit'),
          )
      )
  ));

  Also see:
  /admin/users/staff.php 'limit' => 250,
  /admin/users/admins.php 'limit' => 250,

  /group/inviteusers.php 'limit' => 100,
  /group/suggest.php 'limit' => 100,

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1435408/+subscriptions


Follow ups

References