← Back to team overview

mahara-contributors team mailing list archive

[Bug 1444457] [NEW] Standarize the call of some image files

 

Public bug reported:

The following images call are incorrect and may be modified to use the $THEME->get_image_url() method:
htdocs/artefact/blog/atom.php	 line 91, column 77
htdocs/export/html/lib.php	 line 258, column 82
htdocs/interaction/forum/atom.php	 line 151, column 69
htdocs/theme/raw/artefact/file/export/html/templates/index.tpl	 line 23, column 76
htdocs/theme/raw/artefact/file/export/html/templates/index.tpl	 line 32, column 76
htdocs/theme/raw/artefact/file/export/html/templates/index.tpl	 line 41, column 74
htdocs/theme/raw/artefact/internal/blocktype/socialprofile/templates/content.tpl	 line 11, column 115
htdocs/theme/raw/artefact/plans/templates/taskrows.tpl	 line 13, column 101
htdocs/theme/raw/artefact/plans/templates/taskrows.tpl	 line 27, column 104
htdocs/theme/raw/artefact/plans/templates/taskslist.tpl	 line 8, column 94
htdocs/theme/raw/artefact/plans/templates/taskslist.tpl	 line 16, column 97
htdocs/theme/raw/pieforms/viewlayout.php	 line 33, column 151
htdocs/theme/raw/pieforms/viewlayout.php	 line 96, column 151
htdocs/theme/raw/search/elasticsearch/templates/artefact.tpl	 line 7, column 135

Also, the following language packs may use parameters instead of
hardcoding images :

htdocs/lang/en.utf8/help/forms/accountprefs.addremovecolumns.html	 line 4, column 111
htdocs/lang/en.utf8/help/forms/accountprefs.addremovecolumns.html	 line 4, column 188
htdocs/lang/en.utf8/help/forms/adduser.addremovecolumns.html	 line 4, column 108
htdocs/lang/en.utf8/help/forms/adduser.addremovecolumns.html	 line 4, column 181
htdocs/lang/en.utf8/help/forms/license.icon.html	 line 6, column 23
htdocs/lang/en.utf8/help/forms/license.icon.html	 line 7, column 33
htdocs/lang/en.utf8/help/forms/uploadcsv.addremovecolumns.html	 line 4, column 117
htdocs/lang/en.utf8/help/forms/uploadcsv.addremovecolumns.html	 line 4, column 194

** Affects: mahara
     Importance: Undecided
         Status: New

** Description changed:

  The following images call are incorrect and may be modified to use the $THEME->get_image_url() method:
- htdocs/artefact/blog/atom.php	 line 91, column 77	$image = get_config('wwwroot') . 'theme/raw/static/images/site-logo.png';
- htdocs/export/html/lib.php	 line 258, column 82	$smarty->assign('maharalogo', $rootpath . $this->theme_path('images/logo.png'));
- htdocs/interaction/forum/atom.php	 line 151, column 69	$image = get_config('wwwroot') . 'theme/raw/static/images/site-logo.png';
- htdocs/theme/raw/artefact/file/export/html/templates/index.tpl	 line 23, column 76	<td><img src="{$rootpath}static/artefact/file/static/images/folder.png" alt="{str tag=Folder section=artefact.file}"></td>
- htdocs/theme/raw/artefact/file/export/html/templates/index.tpl	 line 32, column 76	<td><img src="{$rootpath}static/artefact/file/static/images/folder.png" alt="{str tag=Folder section=artefact.file}"></td>
- htdocs/theme/raw/artefact/file/export/html/templates/index.tpl	 line 41, column 74	<td><img src="{$rootpath}static/artefact/file/static/images/file.png" alt="{str tag=File section=artefact.file}"></td>
- htdocs/theme/raw/artefact/internal/blocktype/socialprofile/templates/content.tpl	 line 11, column 115	{if $showicon}<img src="{$WWWROOT}artefact/internal/blocktype/socialprofile/theme/raw/static/images/email.png" alt="{$email}" class="valign-top">{/if}
- htdocs/theme/raw/artefact/plans/templates/taskrows.tpl	 line 13, column 101	<td class="c3 incomplete"><img src="{$WWWROOT}theme/raw/static/images/failure_small.png" alt="{str tag=overdue section=artefact.plans}" /></td>
- htdocs/theme/raw/artefact/plans/templates/taskrows.tpl	 line 27, column 104	<td class="c3 completed"><img src="{$WWWROOT}theme/raw/static/images/success_small.png" alt="{str tag=completed section=artefact.plans}" /></td>
- htdocs/theme/raw/artefact/plans/templates/taskslist.tpl	 line 8, column 94	<td class="incomplete"><img src="{$WWWROOT}theme/raw/static/images/failure_small.png" alt="{str tag=overdue section=artefact.plans}" /></td>
- htdocs/theme/raw/artefact/plans/templates/taskslist.tpl	 line 16, column 97	<td class="completed"><img src="{$WWWROOT}theme/raw/static/images/success_small.png" alt="{str tag=completed section=artefact.plans}" /></td>
- htdocs/theme/raw/pieforms/viewlayout.php	 line 33, column 151	. '<img title="' . get_string('Help', 'view') . '" alt="' . get_string('Help', 'view') . '" src="' . $wwwroot . 'theme/raw/static/images/help.png">'
- htdocs/theme/raw/pieforms/viewlayout.php	 line 96, column 151	. '<img title="' . get_string('Help', 'view') . '" alt="' . get_string('Help', 'view') . '" src="' . $wwwroot . 'theme/raw/static/images/help.png">'
- htdocs/theme/raw/search/elasticsearch/templates/artefact.tpl	 line 7, column 135	<div class="thumbnail-image"><img src="{$WWWROOT}search/elasticsearch/theme/raw/static/images/thumbnail-{$secfacetterm|lower}.png" alt=""></div>
+ htdocs/artefact/blog/atom.php	 line 91, column 77
+ htdocs/export/html/lib.php	 line 258, column 82
+ htdocs/interaction/forum/atom.php	 line 151, column 69
+ htdocs/theme/raw/artefact/file/export/html/templates/index.tpl	 line 23, column 76
+ htdocs/theme/raw/artefact/file/export/html/templates/index.tpl	 line 32, column 76
+ htdocs/theme/raw/artefact/file/export/html/templates/index.tpl	 line 41, column 74
+ htdocs/theme/raw/artefact/internal/blocktype/socialprofile/templates/content.tpl	 line 11, column 115
+ htdocs/theme/raw/artefact/plans/templates/taskrows.tpl	 line 13, column 101
+ htdocs/theme/raw/artefact/plans/templates/taskrows.tpl	 line 27, column 104
+ htdocs/theme/raw/artefact/plans/templates/taskslist.tpl	 line 8, column 94
+ htdocs/theme/raw/artefact/plans/templates/taskslist.tpl	 line 16, column 97
+ htdocs/theme/raw/pieforms/viewlayout.php	 line 33, column 151
+ htdocs/theme/raw/pieforms/viewlayout.php	 line 96, column 151
+ htdocs/theme/raw/search/elasticsearch/templates/artefact.tpl	 line 7, column 135
  
- Also, the following language packs may use parameters instead of hardcoding images :
- htdocs/lang/en.utf8/help/forms/accountprefs.addremovecolumns.html	 line 4, column 111	<p>You can choose to display a row with the buttons <img src="../../theme/raw/static/images/btn_addcolumnleft.png" alt="add"> and <img src="../../theme/raw/static/images/btn_removecolumn.png" alt="remove"> in the page editor. These buttons add and remove columns from that page when you click on them.</p>
- htdocs/lang/en.utf8/help/forms/accountprefs.addremovecolumns.html	 line 4, column 188	<p>You can choose to display a row with the buttons <img src="../../theme/raw/static/images/btn_addcolumnleft.png" alt="add"> and <img src="../../theme/raw/static/images/btn_removecolumn.png" alt="remove"> in the page editor. These buttons add and remove columns from that page when you click on them.</p>
- htdocs/lang/en.utf8/help/forms/adduser.addremovecolumns.html	 line 4, column 108	<p>You can choose to display a row with  buttons <img src="../../theme/raw/static/images/btn_addcolumnleft.png" alt="add"> <img src="../../theme/raw/static/images/btn_removecolumn.png" alt="remove"> in the page editor. These buttons add and remove columns from that page.</p>
- htdocs/lang/en.utf8/help/forms/adduser.addremovecolumns.html	 line 4, column 181	<p>You can choose to display a row with  buttons <img src="../../theme/raw/static/images/btn_addcolumnleft.png" alt="add"> <img src="../../theme/raw/static/images/btn_removecolumn.png" alt="remove"> in the page editor. These buttons add and remove columns from that page.</p>
- htdocs/lang/en.utf8/help/forms/license.icon.html	 line 6, column 23	URL <pre>license:gfdl.png</pre> would refer to the file
- htdocs/lang/en.utf8/help/forms/license.icon.html	 line 7, column 33	<pre>static/images/license/gfdl.png</pre> in the theme.</p>
- htdocs/lang/en.utf8/help/forms/uploadcsv.addremovecolumns.html	 line 4, column 117	<p>The users can choose to display a row with the buttons <img src="../../theme/raw/static/images/btn_addcolumnleft.png" alt="add"> and <img src="../../theme/raw/static/images/btn_removecolumn.png" alt="remove"> in the page editor. These buttons add and remove columns from that page when you click on them.</p>
- htdocs/lang/en.utf8/help/forms/uploadcsv.addremovecolumns.html	 line 4, column 194	<p>The users can choose to display a row with the buttons <img src="../../theme/raw/static/images/btn_addcolumnleft.png" alt="add"> and <img src="../../theme/raw/static/images/btn_removecolumn.png" alt="remove"> in the page editor. These buttons add and remove columns from that page when you click on them.</p>
+ Also, the following language packs may use parameters instead of
+ hardcoding images :
+ 
+ htdocs/lang/en.utf8/help/forms/accountprefs.addremovecolumns.html	 line 4, column 111
+ htdocs/lang/en.utf8/help/forms/accountprefs.addremovecolumns.html	 line 4, column 188
+ htdocs/lang/en.utf8/help/forms/adduser.addremovecolumns.html	 line 4, column 108
+ htdocs/lang/en.utf8/help/forms/adduser.addremovecolumns.html	 line 4, column 181
+ htdocs/lang/en.utf8/help/forms/license.icon.html	 line 6, column 23
+ htdocs/lang/en.utf8/help/forms/license.icon.html	 line 7, column 33
+ htdocs/lang/en.utf8/help/forms/uploadcsv.addremovecolumns.html	 line 4, column 117
+ htdocs/lang/en.utf8/help/forms/uploadcsv.addremovecolumns.html	 line 4, column 194

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1444457

Title:
  Standarize the call of some image files

Status in Mahara ePortfolio:
  New

Bug description:
  The following images call are incorrect and may be modified to use the $THEME->get_image_url() method:
  htdocs/artefact/blog/atom.php	 line 91, column 77
  htdocs/export/html/lib.php	 line 258, column 82
  htdocs/interaction/forum/atom.php	 line 151, column 69
  htdocs/theme/raw/artefact/file/export/html/templates/index.tpl	 line 23, column 76
  htdocs/theme/raw/artefact/file/export/html/templates/index.tpl	 line 32, column 76
  htdocs/theme/raw/artefact/file/export/html/templates/index.tpl	 line 41, column 74
  htdocs/theme/raw/artefact/internal/blocktype/socialprofile/templates/content.tpl	 line 11, column 115
  htdocs/theme/raw/artefact/plans/templates/taskrows.tpl	 line 13, column 101
  htdocs/theme/raw/artefact/plans/templates/taskrows.tpl	 line 27, column 104
  htdocs/theme/raw/artefact/plans/templates/taskslist.tpl	 line 8, column 94
  htdocs/theme/raw/artefact/plans/templates/taskslist.tpl	 line 16, column 97
  htdocs/theme/raw/pieforms/viewlayout.php	 line 33, column 151
  htdocs/theme/raw/pieforms/viewlayout.php	 line 96, column 151
  htdocs/theme/raw/search/elasticsearch/templates/artefact.tpl	 line 7, column 135

  Also, the following language packs may use parameters instead of
  hardcoding images :

  htdocs/lang/en.utf8/help/forms/accountprefs.addremovecolumns.html	 line 4, column 111
  htdocs/lang/en.utf8/help/forms/accountprefs.addremovecolumns.html	 line 4, column 188
  htdocs/lang/en.utf8/help/forms/adduser.addremovecolumns.html	 line 4, column 108
  htdocs/lang/en.utf8/help/forms/adduser.addremovecolumns.html	 line 4, column 181
  htdocs/lang/en.utf8/help/forms/license.icon.html	 line 6, column 23
  htdocs/lang/en.utf8/help/forms/license.icon.html	 line 7, column 33
  htdocs/lang/en.utf8/help/forms/uploadcsv.addremovecolumns.html	 line 4, column 117
  htdocs/lang/en.utf8/help/forms/uploadcsv.addremovecolumns.html	 line 4, column 194

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1444457/+subscriptions


Follow ups

References