← Back to team overview

mahara-contributors team mailing list archive

[Bug 1386970] Re: Missing title tag on file unzip button

 

** Changed in: mahara
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1386970

Title:
  Missing title tag on file unzip button

Status in Mahara ePortfolio:
  Fix Released
Status in Mahara 1.10 series:
  Fix Released
Status in Mahara 1.9 series:
  Fix Released
Status in Mahara 15.04 series:
  Fix Released

Bug description:
  The alt text for the "unzip", "edit", and "delete" buttons in the
  Content -> Files are, contains unescaped double quotes.

  <img alt="Decompress "3077-1316797096-PVE.zip"" src="http://vegas.wgtn
  .cat-it.co.nz/mahara/htdocs/theme/raw/static/images/btn_extract.png">

  These should be escaped into HTML entities (by being passed through
  htmlspecialchars()/hsc())

  <img alt="Decompress &quot;3077-1316797096-PVE.zip&quot;"
  src="http://vegas.wgtn.cat-
  it.co.nz/mahara/htdocs/theme/raw/static/images/btn_extract.png">

  This breaks the alt tag, and it also causes problems for our Behat
  testers because without the alt tag there's no way to uniquely
  identify one of these.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1386970/+subscriptions


References