← Back to team overview

mahara-contributors team mailing list archive

[Bug 1417120] A change has been merged

 

Reviewed:  https://reviews.mahara.org/4805
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/1a691a9854455903f014192316cd3c7116986c4d
Submitter: Aaron Wells (aaronw@xxxxxxxxxxxxxxx)
Branch:    15.04_STABLE

commit 1a691a9854455903f014192316cd3c7116986c4d
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Wed May 20 10:44:06 2015 +1200

Allowing for non english theme / plugin lang files to be used

Bug 1417120

The language location check now goes in this order:

1. /local string in selected language
2. theme/plugin directory, in selected language
3. langpack, in selected language
4. /local string in parent language (if any)
5. theme/plugin directory, in parent language
6. langpack, in parent language
7. /local string in English
8. theme/plugin directory, in English

Change-Id: I24f61e24fadbca3a62fefa3855f4f444165d750a
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit 1d7a1fa4252bd4c07d4277bf6a54bf354fbe1471)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1417120

Title:
  Non-English lang strings distributed with Themes & Plugins aren't
  loaded.

Status in Mahara ePortfolio:
  Fix Committed
Status in Mahara 1.10 series:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed

Bug description:
  Based on the doc here:
  https://wiki.mahara.org/index.php/Customising/Themes/1.10#Theme_lang_strings

  Theme language strings work in English, but non-English theme language
  strings are not loaded.

  To reproduce:
  1. On a custom theme add a French lang string like explained here:
  https://wiki.mahara.org/index.php/Customising/Themes/1.10#Theme_lang_strings

  2. Change your language to French

  Expected:
  The French lang string should be used

  Actual:
  The French lang string is not used

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1417120/+subscriptions


References