← Back to team overview

mahara-contributors team mailing list archive

[Bug 1455265] A change has been merged

 

Reviewed:  https://reviews.mahara.org/4798
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/537eb4092bcd5cbc412fec6eaad04332e32b2020
Submitter: Aaron Wells (aaronw@xxxxxxxxxxxxxxx)
Branch:    master

commit 537eb4092bcd5cbc412fec6eaad04332e32b2020
Author: Son Nguyen <son.nguyen@xxxxxxxxxxxxxxx>
Date:   Wed May 27 10:53:55 2015 +1200

Remove classes .vertcentre .configure .blockinstane of
div#configureblock when enter fullscreen mode. Bug 1455265

As the class has transformations, it affect the fullscreen function
to get the correct position, width, and height values.

Change-Id: I3dbd590da8b1c992a296704a7c67b9f6394efad3

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1455265

Title:
  TinyMCE "full screen" button doesn't work in block config

Status in Mahara ePortfolio:
  Fix Committed
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  Fix Committed

Bug description:
  Mahara 1504

  It appears that the fullscreen is not fullscreen in 1504. I tried on a
  couple instances, including master.dev.mahara.org and various
  browsers. Adding screenshot also

  To replicate:

  1. Create a page
  2. Go to the "Edit Content" tab
  3. Put a text block onto the page
  4. Click the "Toggle toolbars" button on TinyMCE to expose the fullscreen button (it's on the right end of the second row of buttons)
  5. Click the "Fullscreen" button

  Expected result:
  TinyMCE goes to full screen (fills the whole browser window)

  Actual result:
  TinyMCE only fills the block config iframe. This actually makes it *smaller* than before.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1455265/+subscriptions


References