← Back to team overview

mahara-contributors team mailing list archive

[Bug 1465107] Re: Use the Bootstrap CSS framework

 

Hi just found that the following fix broke the image license:
https://github.com/MaharaProject/mahara/commit/75f77523122c1394cd0d154f8c9a23522c2422ba

That will not work if we keep the file extension.

The following task was created to address the correct use of the get_image_url method in this context:
https://bugs.launchpad.net/mahara/+bug/1444461

Also, the following fix broke some remaining get_themeurl call:
https://github.com/MaharaProject/mahara/commit/74b5a5e0a5989670a48199413fb646a72170bc95#diff-109

in the file artefact/file/js, there is two remaining call of the
get_themeurl() method that cannot work right now because there is no
config.theme value inserted.

Maybe we should convert them in the font awesome spinner icon.

The call of SVG file in Javascript was reported here:
https://bugs.launchpad.net/mahara/+bug/1436854

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1465107

Title:
  Use the Bootstrap CSS framework

Status in Mahara ePortfolio:
  In Progress

Bug description:
  Mahara's CSS, and general front-end coding, is a bit chaotic. So for
  the past several months we've had a couple of front-end developers
  working on rewriting the entire Mahara front end to use the Bootstrap
  CSS framework. http://getbootstrap.com/css/

  This should make all of our front-end development work easier
  henceforth, as well as providing a nice set of standard widgets to
  make Mahara look better right away.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1465107/+subscriptions


References