mahara-contributors team mailing list archive

[Aaron Wells <1499122@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

To replicate:

1. Clean install of Mahara
2. In the "No institution" settings, turn on threaded comments. Leave the comment sort order on the default "ascending"
3. Create a page
4. Leave about 10 comments on the page. Don't make any of them be replies.

Expected result: Because the comments aren't replies, they should be displayed on the page in the order they were created
Actual result: After the first few comments are posted, comments will start showing up at the top of the list of comments

The reason for this is because the sortorder for "threaded ascending" is
(artefact.path, artefact.ctime, id). Since artefact.path is a string,
and gets sorted in alphabetical order, when the artefact IDs go from 1
digit to 2 digits, the 1 digit ones will start sorting below the 2 digit
ones. I.e. "/11" comes before "/6", in string sorting order.

A similar thing will happen if threaded comments are sorted in
descending order.

** Affects: mahara
     Importance: High
     Assignee: Aaron Wells (u-aaronw)
         Status: Confirmed

** Affects: mahara/15.10
     Importance: High
     Assignee: Aaron Wells (u-aaronw)
         Status: Confirmed

** Changed in: mahara
   Importance: Undecided => High

** Changed in: mahara
       Status: New => Confirmed

** Also affects: mahara/15.10
   Importance: High
       Status: Confirmed

** Changed in: mahara/15.10
    Milestone: None => 15.10.0

** Changed in: mahara/15.10
     Assignee: (unassigned) => Aaron Wells (u-aaronw)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1499122

Title:
  Threaded comments display in the wrong order

Status in Mahara:
  Confirmed
Status in Mahara 15.10 series:
  Confirmed

Bug description:
  To replicate:

  1. Clean install of Mahara
  2. In the "No institution" settings, turn on threaded comments. Leave the comment sort order on the default "ascending"
  3. Create a page
  4. Leave about 10 comments on the page. Don't make any of them be replies.

  Expected result: Because the comments aren't replies, they should be displayed on the page in the order they were created
  Actual result: After the first few comments are posted, comments will start showing up at the top of the list of comments

  The reason for this is because the sortorder for "threaded ascending"
  is (artefact.path, artefact.ctime, id). Since artefact.path is a
  string, and gets sorted in alphabetical order, when the artefact IDs
  go from 1 digit to 2 digits, the 1 digit ones will start sorting below
  the 2 digit ones. I.e. "/11" comes before "/6", in string sorting
  order.

  A similar thing will happen if threaded comments are sorted in
  descending order.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1499122/+subscriptions