mahara-contributors team mailing list archive

[Son Nguyen <1499122@xxxxxxxxxxxxxxxxxx>]

The drawbacka of using paddedpath for sorting are the fix number of padding 0 and the limit depth of the path.
This will cause the wrong order when the artefact id is too big or for some reasons, the db admin set a big number for starting the artefact id.

I have a better idea for this but require more work
We will add a column 'threadedorder' to the table artefact_comment_comment which store the position of the comment in the list of threaded comments for a page/artefact.
When a comment is added, we will update the position of the comment and other following comments in the list.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1499122

Title:
  Threaded comments display in the wrong order

Status in Mahara:
  Confirmed
Status in Mahara 15.10 series:
  Confirmed
Status in Mahara 16.04 series:
  In Progress

Bug description:
  To replicate:

  1. Clean install of Mahara
  2. In the "No institution" settings, turn on threaded comments. Leave the comment sort order on the default "ascending"
  3. Create a page
  4. Leave about 10 comments on the page. Don't make any of them be replies.

  Expected result: Because the comments aren't replies, they should be displayed on the page in the order they were created
  Actual result: After the first few comments are posted, comments will start showing up at the top of the list of comments

  The reason for this is because the sortorder for "threaded ascending"
  is (artefact.path, artefact.ctime, id). Since artefact.path is a
  string, and gets sorted in alphabetical order, when the artefact IDs
  go from 1 digit to 2 digits, the 1 digit ones will start sorting below
  the 2 digit ones. I.e. "/11" comes before "/6", in string sorting
  order.

  A similar thing will happen if threaded comments are sorted in
  descending order.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1499122/+subscriptions