mahara-contributors team mailing list archive

[Jono Mingard <jonom@xxxxxxxxxxxxxxx>]

Public bug reported:

When getting a string with AJAX, arguments to be substituted into the
string are passed to the server and are substituted before the response
is sent back. This causes problems when a string is used twice with
different arguments - the response with the first arguments substituted
is cached, and is reused the second time (therefore ignoring the second
set of arguments).

It would be much more robust to return a string from the server with
"%s"s intact so that interpolation can happen each time it is used on
the client.

** Affects: mahara
     Importance: Medium
     Assignee: Jono Mingard (mingard)
         Status: Confirmed

** Changed in: mahara
       Status: New => Confirmed

** Changed in: mahara
   Importance: Undecided => Medium

** Changed in: mahara
     Assignee: (unassigned) => Jono Mingard (mingard)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1499583

Title:
  get_string_ajax() doesn't work properly with arguments

Status in Mahara:
  Confirmed

Bug description:
  When getting a string with AJAX, arguments to be substituted into the
  string are passed to the server and are substituted before the
  response is sent back. This causes problems when a string is used
  twice with different arguments - the response with the first arguments
  substituted is cached, and is reused the second time (therefore
  ignoring the second set of arguments).

  It would be much more robust to return a string from the server with
  "%s"s intact so that interpolation can happen each time it is used on
  the client.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1499583/+subscriptions