mahara-contributors team mailing list archive

[Mahara Bot <1499583@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/5368
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/897b987a18f121a3f99a1a7e5217e3e325a751b5
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 897b987a18f121a3f99a1a7e5217e3e325a751b5
Author: Jono Mingard <jonom@xxxxxxxxxxxxxxx>
Date:   Fri Sep 25 15:03:27 2015 +1200

Allow repeated use of get_string_ajax with arguments (Bug #1499583)

Return a raw string instead of a formatted one when requested with
AJAX.

behatnotneeded

Change-Id: Ie6711e14b85b79888013e4621c01e2f8fdf3f34a

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1499583

Title:
  get_string_ajax() doesn't work properly with arguments

Status in Mahara:
  Fix Committed

Bug description:
  When getting a string with AJAX, arguments to be substituted into the
  string are passed to the server and are substituted before the
  response is sent back. This causes problems when a string is used
  twice with different arguments - the response with the first arguments
  substituted is cached, and is reused the second time (therefore
  ignoring the second set of arguments).

  It would be much more robust to return a string from the server with
  "%s"s intact so that interpolation can happen each time it is used on
  the client.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1499583/+subscriptions