mahara-contributors team mailing list archive

[Mahara Bot <1512525@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/5659
Committed: https://git.mahara.org/mahara/mahara/commit/5648eb16adbd78559057f681efe2dc34e8bbe8ec
Submitter: Aaron Wells (aaronw@xxxxxxxxxxxxxxx)
Branch:    15.10_STABLE

commit 5648eb16adbd78559057f681efe2dc34e8bbe8ec
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Tue Nov 3 12:46:21 2015 +1300

Bug 1512525: Empty comment description causes display brokenness

So I'm giving it some invisible content, eg a non-breaking space, so
that the floats position correctly.

Behatnotneeded: It is a visual issue

Change-Id: If9bd1f67868f612087c683b57a6527fca3122a3f
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit ba6d2cba7c1661516653f94a881909a5c24b1e0c)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1512525

Title:
  Comments with attachments but no description look broken on large
  screen

Status in Mahara:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed

Bug description:
  Problem here is the float for the attachments is not pushed to the
  right as there is no content for the description float so it has no
  solidity.

  to fix I'll add a content::after to the description element to add a
  non-breaking space.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1512525/+subscriptions