← Back to team overview

mahara-contributors team mailing list archive

[Bug 1522659] [NEW] Have require of pieform more centralised

 

Public bug reported:

Discovered when fixing another problem that some pages get their Pieform
class via the require_once('pieforms/pieform.php'); via the
auth_check_required_fields() function, while all the others get it via
thier own require_once('pieforms/pieform.php'); within the top of the
file.

When all we need is for is the pieform() function that calls the Pieform
class to make sure the required file is included.

So will submit a code tidying up patch

** Affects: mahara
     Importance: Low
     Assignee: Robert Lyon (robertl-9)
         Status: In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1522659

Title:
  Have require of pieform more centralised

Status in Mahara:
  In Progress

Bug description:
  Discovered when fixing another problem that some pages get their
  Pieform class via the require_once('pieforms/pieform.php'); via the
  auth_check_required_fields() function, while all the others get it via
  thier own require_once('pieforms/pieform.php'); within the top of the
  file.

  When all we need is for is the pieform() function that calls the
  Pieform class to make sure the required file is included.

  So will submit a code tidying up patch

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1522659/+subscriptions


Follow ups