mahara-contributors team mailing list archive

[Mahara Bot <1522659@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/5816
Committed: https://git.mahara.org/mahara/mahara/commit/eb396d025e3d26f639da506e948a1a6bd3cd95d0
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit eb396d025e3d26f639da506e948a1a6bd3cd95d0
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Fri Dec 4 15:02:40 2015 +1300

Bug 1522659: Centeralising the require to pieform file

behatnotneeded - existing tests should suffice

Change-Id: I69a59b5f70bc6e5e3379106faf975f9c99af07b0
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1522659

Title:
  Have require of pieform more centralised

Status in Mahara:
  Fix Committed

Bug description:
  Discovered when fixing another problem that some pages get their
  Pieform class via the require_once('pieforms/pieform.php'); via the
  auth_check_required_fields() function, while all the others get it via
  thier own require_once('pieforms/pieform.php'); within the top of the
  file.

  When all we need is for is the pieform() function that calls the
  Pieform class to make sure the required file is included.

  So will submit a code tidying up patch

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1522659/+subscriptions