← Back to team overview

mahara-contributors team mailing list archive

[Bug 1538225] Re: Notification for user added to institution is not in the recipient's language

 

Hi Jan,

>From what I can tell from looking at the code is that the language for the email messages sent out is based on three possible values:
- What language the Mahara site is set to
- What language the Institution is set to
- What language the user has as their language preference

When a user is added to an institution the code first checks what the
institution's language is set to and if it set to 'site default' then it
will be based on what the site's language is set to.

So what is missing from this scenario is the user's language preference,
if set, is being ignored.

I've added a patch for review to deal with this situation
https://reviews.mahara.org/#/c/5970/

Cheers

Robert




I've added a patch to make that the first choice of what language the email is sent in.

** Changed in: mahara
    Milestone: None => 16.04.0

** Changed in: mahara
     Assignee: (unassigned) => Robert Lyon (robertl-9)

** Changed in: mahara
   Importance: Undecided => Medium

** Changed in: mahara
       Status: New => In Progress

** Changed in: mahara
   Importance: Medium => High

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1538225

Title:
  Notification for user added to institution is not in the recipient's
  language

Status in Mahara:
  In Progress

Bug description:
  When a user is added to an institution using the "Add members" button
  on the "Institution members" page, the notification sent to the user
  is in the language that the admin/staff, i.e. the one who added the
  user, currently uses.

  Example: Admin's language is English, user's language is German. Admin adds the user to an institution by selecting him/her from either the "Users who have requested membership" list or the "Non-members" list and clicking on "Add members". User receives the notification in English:
  "Institution membership confirmation
  You have been added as a member of Test Institution."

  When the admin's language is changed, the notification in sent in the
  respective language.

  The notification must be in the recipient's language, regardless of
  the admin's or staff's language.

  
  Mahara version: 15.10.1
  Chromium browser v48, Linux, Postgres

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1538225/+subscriptions


References