mahara-contributors team mailing list archive

[Aaron Wells <1588606@xxxxxxxxxxxxxxxxxx>]

I'm noticing some inconsistencies still:

1. Go to Administration -> Configure site -> Pages -> Edit group
homepage

2. Notice how it has a "Display page" link, and links to the "edit
content" screen, the "edit layout" screen, and the "choose skin" screen.

3. Click on the "edit layout" button

4. Notice how the "Edit layout" screen doesn't have a "Display page"
link or a link to the "Choose skin" screen.

Expected result: The "Edit content" screen should be limited in the same
way as the "Edit layout" screen.

The underlying problem here is that layout.php (which loads up the "Edit
Layout" screen) correctly populates the "issitetemplate" smarty
variable, but blocks.php (which loads the "Edit content" screen) does
not. So although both screens use editviewtabs.tpl, they display it
differently.

** Changed in: mahara/16.10
       Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1588606

Title:
  Properly checking if group template is a site template

Status in Mahara:
  Fix Committed
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  The $view->get('template') returns a string where as the constant
  View::SITE_TEMPLATE is an integer so we can't compare them via ===

  We can use == as View::SITE_TEMPLATE = 2

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1588606/+subscriptions