mahara-contributors team mailing list archive

[Robert Lyon <robertl@xxxxxxxxxxxxxxx>]

Public bug reported:

The $view->get('template') returns a string where as the constant
View::SITE_TEMPLATE is an integer so we can't compare them via ===

We can use == as View::SITE_TEMPLATE = 2

** Affects: mahara
     Importance: High
     Assignee: Robert Lyon (robertl-9)
         Status: In Progress

** Affects: mahara/16.04
     Importance: High
         Status: In Progress

** Affects: mahara/16.10
     Importance: High
     Assignee: Robert Lyon (robertl-9)
         Status: In Progress

** Also affects: mahara/16.04
   Importance: Undecided
       Status: New

** Also affects: mahara/16.10
   Importance: High
     Assignee: Robert Lyon (robertl-9)
       Status: In Progress

** Changed in: mahara/16.10
    Milestone: None => 16.10.0

** Changed in: mahara/16.04
    Milestone: None => 16.04.1

** Changed in: mahara/16.04
   Importance: Undecided => High

** Changed in: mahara/16.04
       Status: New => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1588606

Title:
  Properly checking if group template is a site template

Status in Mahara:
  In Progress
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  In Progress

Bug description:
  The $view->get('template') returns a string where as the constant
  View::SITE_TEMPLATE is an integer so we can't compare them via ===

  We can use == as View::SITE_TEMPLATE = 2

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1588606/+subscriptions