mahara-contributors team mailing list archive

[Mahara Bot <1588606@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/6567
Committed: https://git.mahara.org/mahara/mahara/commit/fce3ece8edb988169ef7d748e2722107a5c362b3
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    16.04_STABLE

commit fce3ece8edb988169ef7d748e2722107a5c362b3
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Fri Jun 3 16:48:10 2016 +1200

Bug 1588606: Properly checking for site templates

An oversite when Bug 1397110 was tested

behatnotneeded

Change-Id: I1772d27bb1ec099a26149551f82cf6ea365bb780
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit e174049ba89ecf48247f32544c56d77e60f65e36)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1588606

Title:
  Properly checking if group template is a site template

Status in Mahara:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  The $view->get('template') returns a string where as the constant
  View::SITE_TEMPLATE is an integer so we can't compare them via ===

  We can use == as View::SITE_TEMPLATE = 2

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1588606/+subscriptions