← Back to team overview

mahara-contributors team mailing list archive

[Bug 1590300] Re: Weirdness in edit tabs for site templates

 

** Changed in: mahara/16.10
       Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1590300

Title:
  Weirdness in edit tabs for site templates

Status in Mahara:
  Fix Committed
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  I noticed this irregularity while testing out the patch for Bug
  1588606:

  1. Go to Administration -> Configure site -> Pages -> Edit group
  homepage

  2. Notice how it has a "Display page" link, and links to the "edit
  content" screen, the "edit layout" screen, and the "choose skin"
  screen.

  3. Click on the "edit layout" button

  4. Notice how the "Edit layout" screen doesn't have a "Display page"
  link or a link to the "Choose skin" screen.

  Expected result: The "Edit content" screen should be limited in the
  same way as the "Edit layout" screen.

  The underlying problem here is that layout.php (which loads up the
  "Edit Layout" screen) correctly populates the "issitetemplate" smarty
  variable, but blocks.php (which loads the "Edit content" screen) does
  not. So although both screens use editviewtabs.tpl, they display it
  differently.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1590300/+subscriptions


References