mahara-contributors team mailing list archive

[Mahara Bot <1590300@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/6568
Committed: https://git.mahara.org/mahara/mahara/commit/ac9a33a679ff26621324560984446c86e8a8430a
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit ac9a33a679ff26621324560984446c86e8a8430a
Author: Aaron Wells <aaronw@xxxxxxxxxxxxxxx>
Date:   Wed Jun 8 19:53:07 2016 +1200

Bug 1590300: Typo in smarty variable

Regression from Bug 1397110

Change-Id: I6f98131dd61e06d0bc9d268bbe3eee1c4d4fbcb0
behatnotneeded: covered by existing tests

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1590300

Title:
  Weirdness in edit tabs for site templates

Status in Mahara:
  Fix Committed
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  I noticed this irregularity while testing out the patch for Bug
  1588606:

  1. Go to Administration -> Configure site -> Pages -> Edit group
  homepage

  2. Notice how it has a "Display page" link, and links to the "edit
  content" screen, the "edit layout" screen, and the "choose skin"
  screen.

  3. Click on the "edit layout" button

  4. Notice how the "Edit layout" screen doesn't have a "Display page"
  link or a link to the "Choose skin" screen.

  Expected result: The "Edit content" screen should be limited in the
  same way as the "Edit layout" screen.

  The underlying problem here is that layout.php (which loads up the
  "Edit Layout" screen) correctly populates the "issitetemplate" smarty
  variable, but blocks.php (which loads the "Edit content" screen) does
  not. So although both screens use editviewtabs.tpl, they display it
  differently.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1590300/+subscriptions