mahara-contributors team mailing list archive
-
mahara-contributors team
-
Mailing list archive
-
Message #36906
[Bug 1609112] [NEW] The is_plugin_active() function can give false positives
Public bug reported:
This is due to the fact that we have different plugin types with the
same name, eg:
Artefact | Blocktype
-----------+------------
blog | blog
comment | comment
annotation | annotation
And that we check the type 'artefact' first so in the case of the
Artefact 'annotation' being active but the blocktype 'annotation' not
being active we will get 'true' from is_plugin_active()
We need to alter the function and pass it a 'type' so we can indicate
which of the types we are interested in.
I'll mark this as 'high' as this could lead to confusion in the use of
the function.
** Affects: mahara
Importance: High
Assignee: Robert Lyon (robertl-9)
Status: In Progress
** Affects: mahara/15.04
Importance: High
Status: In Progress
** Affects: mahara/15.10
Importance: High
Status: In Progress
** Affects: mahara/16.04
Importance: High
Status: In Progress
** Affects: mahara/16.10
Importance: High
Assignee: Robert Lyon (robertl-9)
Status: In Progress
** Also affects: mahara/15.04
Importance: Undecided
Status: New
** Also affects: mahara/15.10
Importance: Undecided
Status: New
** Also affects: mahara/16.10
Importance: High
Assignee: Robert Lyon (robertl-9)
Status: In Progress
** Also affects: mahara/16.04
Importance: Undecided
Status: New
** Changed in: mahara/16.04
Importance: Undecided => High
** Changed in: mahara/15.10
Importance: Undecided => High
** Changed in: mahara/15.04
Importance: Undecided => High
** Changed in: mahara/16.04
Status: New => In Progress
** Changed in: mahara/15.10
Status: New => In Progress
** Changed in: mahara/15.04
Status: New => In Progress
** Changed in: mahara/16.04
Milestone: None => 16.04.3
** Changed in: mahara/15.10
Milestone: None => 15.10.5
** Changed in: mahara/15.04
Milestone: None => 15.04.9
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1609112
Title:
The is_plugin_active() function can give false positives
Status in Mahara:
In Progress
Status in Mahara 15.04 series:
In Progress
Status in Mahara 15.10 series:
In Progress
Status in Mahara 16.04 series:
In Progress
Status in Mahara 16.10 series:
In Progress
Bug description:
This is due to the fact that we have different plugin types with the
same name, eg:
Artefact | Blocktype
-----------+------------
blog | blog
comment | comment
annotation | annotation
And that we check the type 'artefact' first so in the case of the
Artefact 'annotation' being active but the blocktype 'annotation' not
being active we will get 'true' from is_plugin_active()
We need to alter the function and pass it a 'type' so we can indicate
which of the types we are interested in.
I'll mark this as 'high' as this could lead to confusion in the use of
the function.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1609112/+subscriptions
Follow ups
-
[Bug 1609112] Re: The is_plugin_active() function can give false positives
From: Robert Lyon, 2016-10-21
-
[Bug 1609112] Re: The is_plugin_active() function can give false positives
From: Robert Lyon, 2016-08-08
-
[Bug 1609112] Re: The is_plugin_active() function can give false positives
From: Aaron Wells, 2016-08-08
-
[Bug 1609112] A change has been merged
From: Mahara Bot, 2016-08-05
-
[Bug 1609112] A change has been merged
From: Mahara Bot, 2016-08-05
-
[Bug 1609112] A change has been merged
From: Mahara Bot, 2016-08-05
-
[Bug 1609112] Re: The is_plugin_active() function can give false positives
From: Robert Lyon, 2016-08-05
-
[Bug 1609112] A patch has been submitted for review
From: Mahara Bot, 2016-08-04
-
[Bug 1609112] A patch has been submitted for review
From: Mahara Bot, 2016-08-04
-
[Bug 1609112] A change has been merged
From: Mahara Bot, 2016-08-04
-
[Bug 1609112] A patch has been submitted for review
From: Mahara Bot, 2016-08-04
-
[Bug 1609112] Re: The is_plugin_active() function can give false positives
From: Aaron Wells, 2016-08-04
-
[Bug 1609112] A patch has been submitted for review
From: Mahara Bot, 2016-08-02