mahara-contributors team mailing list archive

[Mahara Bot <1609112@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/6802
Committed: https://git.mahara.org/mahara/mahara/commit/80f10a5cd72d82d111930d674846bf13a4cdae6c
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    15.04_STABLE

commit 80f10a5cd72d82d111930d674846bf13a4cdae6c
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Wed Aug 3 08:25:09 2016 +1200

Bug 1609112: Pass the plugin type to is_plugin_active()

So that we can differentiate between plugin types that have the same
plugin name, eg comment artefact vs comment blocktype

behatnotneeded

Change-Id: I0f7ffe6da3f7a4ff88cf625a1010c6d2012932d0
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit f30bcd1215f1ef697aa2d463b423596b47a3cbc6)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1609112

Title:
  The is_plugin_active() function can give false positives

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  This is due to the fact that we have different plugin types with the
  same name, eg:

  Artefact   | Blocktype
  -----------+------------
  blog       | blog
  comment    | comment
  annotation | annotation

  And that we check the type 'artefact' first so in the case of the
  Artefact 'annotation' being active but the blocktype 'annotation' not
  being active we will get 'true' from is_plugin_active()

  We need to alter the function and pass it a 'type' so we can indicate
  which of the types we are interested in.

  I'll mark this as 'high' as this could lead to confusion in the use of
  the function.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1609112/+subscriptions