← Back to team overview

mahara-contributors team mailing list archive

[Bug 1611518] A change has been merged

 

Reviewed:  https://reviews.mahara.org/6821
Committed: https://git.mahara.org/mahara/mahara/commit/555d82f9e08e623482c7563df5ef56d1767c8194
Submitter: Son Nguyen (son.nguyen@xxxxxxxxxxxxxxx)
Branch:    master

commit 555d82f9e08e623482c7563df5ef56d1767c8194
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Wed Aug 10 09:19:57 2016 +1200

Bug 1611518: combine_access failing for shared collection

When adding a page to a collection and they have different access rules

Change-Id: Ib45bc551309a592f8863d6ea051f26f07c4797ab
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1611518

Title:
  Unable to add page to shared collection

Status in Mahara:
  In Progress

Bug description:
  To test:

  1) Create a new site
  2) Create a couple of pages
  3) Create a new collection and add the pages to it
  4) Share the collection with registered users
  5) Create another new page
  6) Try and add that to the collection

  You should get an error like:
  [WAR] 67 (lib/errors.php:820) Failed to get a recordset: postgres8 error: [-5: ERROR:  duplicate key value violates unique constraint "viewacce_id_pk"
  DETAIL:  Key (id)=(6) already exists.] 

  This is due to the fact that we have added the 'id' column to the
  view_access table and now the View::combine_access() function make
  everything unique as they all contain a different id

  We need to unset the $a->id like we do for $a->view

  This is regression

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1611518/+subscriptions


References