mahara-contributors team mailing list archive
-
mahara-contributors team
-
Mailing list archive
-
Message #37291
[Bug 1525736] A change has been merged
Reviewed: https://reviews.mahara.org/5848
Committed: https://git.mahara.org/mahara/mahara/commit/e78bbce37119c979346500cd995648441dc39ef2
Submitter: Son Nguyen (son.nguyen@xxxxxxxxxxxxxxx)
Branch: master
commit e78bbce37119c979346500cd995648441dc39ef2
Author: Aaron Wells <aaronw@xxxxxxxxxxxxxxx>
Date: Mon Dec 14 18:45:51 2015 +1300
update_record: Let a column be a data column & a where column
Bug 1525736: Also doing a general cleanup of this very old
and very messy function.
behatnotneeded: Covered by existing tests
Change-Id: I4b2feba22764fd290a69dc4b6ab1d734abd08a1c
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1525736
Title:
update_record() doesn't allow for a column listed in the 'where'
object to be updated
Status in Mahara:
In Progress
Bug description:
If I have a where object like:
stdClass Object (
[localusr] => 11
[authinstance] => 2
)
And data object like:
stdClass Object (
[remoteusername] => 'null@xxxxxxxx'
[authinstance] => 4
[localusr] => 11
)
It will only update the remoteusername and not the authinstance as
well?
The reason for this is that inside update_record() is a foreach loop
to remove any data fields if they match where fields
But we probably don't need to do that.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1525736/+subscriptions
References