mahara-contributors team mailing list archive

[Aaron Wells <1615280@xxxxxxxxxxxxxxxxxx>]

Test instructions:

It seems that not all email fields in Mahara are actually validate at
the time of input. One that I have verified to be validated, is the one
on the admin's "Account settings" screen when viewing the account
settings for another user.

A useful utility for checking whether an email address is a valid format
is https://isemail.info . For the specific use-case described in this
bug, you can use the domain name "example.supplies", which uses the
newish ".supplies" TLD.

1. Log in as admin
2. Create a new Mahara user with username "user1"
3. Go to Administration -> Users -> User search
4. Locate "user1" and click on their username, to bring up their "Account settings" screen.
5. Set the "Primary email" field to "user1@example.supplies" (or another exotic but valid email address)
6. Click "Save changes"

Expected result: The email is updated
Actual result: The form is rejected with the message "Email address is invalid".

** Summary changed:

- Email validation bug (long domains)
+ Email validation rejects top-level domains longer than 4 characters

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1615280

Title:
  Email validation rejects top-level domains longer than 4 characters

Status in Mahara:
  In Progress
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  In Progress

Bug description:
  This one has existed since 2006, but only become an issue with the
  opening up of TLDs over the past few years.
  (https://en.wikipedia.org/wiki/List_of_Internet_top-level_domains)

  Currently the email validation in pieform limits the TLD to between 2-4 characters (see pieform_rule_email() in htdocs/lib/pieforms/pieform/rules/email.php.)
  That means people from .horse, for example, can't register. Changing the regex fixed my immediate problem, haven't tested how the other email validation points react. They use FILTER_VALIDATE_EMAIL and PHPMailer::ValidateAddress, so might be better.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1615280/+subscriptions