mahara-contributors team mailing list archive

[Aaron Wells <1615280@xxxxxxxxxxxxxxxxxx>]

Our testers found that the PHPMailer email validation accepts a few
addresses that are actually invalid:

email@xxxxxxxxxxx (Joe Smith)
email@example
email@xxxxxxxxxxx
email@111.222.333.44444

However, it did not reject any valid addresses. So we could potentially
tighten up the validation in the future, but I think preventing false-
rejections is more important. Plus, Mahara sends out confirmation email
messages whenever a user self-updates their email address, so that's a
kind of "ultimate test" for validity.

** Changed in: mahara/16.10
       Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1615280

Title:
  Email validation rejects top-level domains longer than 4 characters

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  This one has existed since 2006, but only become an issue with the
  opening up of TLDs over the past few years.
  (https://en.wikipedia.org/wiki/List_of_Internet_top-level_domains)

  Currently the email validation in pieform limits the TLD to between 2-4 characters (see pieform_rule_email() in htdocs/lib/pieforms/pieform/rules/email.php.)
  That means people from .horse, for example, can't register. Changing the regex fixed my immediate problem, haven't tested how the other email validation points react. They use FILTER_VALIDATE_EMAIL and PHPMailer::ValidateAddress, so might be better.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1615280/+subscriptions