mahara-contributors team mailing list archive

[Mahara Bot <1677063@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/7578
Committed: https://git.mahara.org/mahara/mahara/commit/c4d74eb06bf9cf25eb6dbbf10d3e680b3ae82155
Submitter: Aaron Wells (aaronw@xxxxxxxxxxxxxxx)
Branch:    master

commit c4d74eb06bf9cf25eb6dbbf10d3e680b3ae82155
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Thu Mar 30 09:58:14 2017 +1300

Bug 1677063: Using correct constructor in XMLDB* classes

behatnotneeded - install of site is good test of this change

Change-Id: I9697ad19afa7e0167aad5b4b468fd86de4132252
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1677063

Title:
  PHP7 deprecated constructor for xmldb

Status in Mahara:
  Fix Committed

Bug description:
  On upgrade I get these errors in error.log

  PHP Deprecated:  Methods with the same name as their class will not be
  constructors in a future version of PHP; XMLDBpostgres has a
  deprecated constructor in /home/robertl/code/mahara-
  devel/mahara/htdocs/lib/xmldb/classes/generators/postgres/postgres.class.php
  on line 31

  We need to update the lib/xmldb/ files so classes are constructed
  correctly

  eg

  Replace

  public function XMLDBpostgres($host, $queryPort)

  with

  public function __construct($host, $queryPort)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1677063/+subscriptions