← Back to team overview

mahara-contributors team mailing list archive

[Bug 1676230] A change has been merged

 

Reviewed:  https://reviews.mahara.org/7567
Committed: https://git.mahara.org/mahara/mahara/commit/8695ca39014060c604c905aa0c697b8e76840ee6
Submitter: Aaron Wells (aaronw@xxxxxxxxxxxxxxx)
Branch:    master

commit 8695ca39014060c604c905aa0c697b8e76840ee6
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Mon Mar 27 14:12:51 2017 +1300

Bug 1676230: Style group view list page for non-editable member
correctly

Previously we had a pair of different templates for this - but we just
need to have a flag to hide edit buttons when one can't doesn't have
edit rites

behatnotneeded

Change-Id: Iff591157ea787f25163c1243789337eceb95b2fd
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1676230

Title:
  group member sees p&c as a list, not boxes

Status in Mahara:
  In Progress

Bug description:
  If we have a user with role=member in a group, and this role cant edit
  the pages at the moment, the p&c screen of the group shows:

  1. An error

  [WAR] d3 (view/groupviews.php:61) Undefined variable: orderby

  This is fixed removing parameter
    'orderby' => $orderby,
  in the pagination configuration in views/groupviews.php. It is ok to remove because we have the parameter repeted and variable $orderby is not defined.

  2. After fixing the error, the pages are displayed in a list and the
  collections can't be seen. They should all be displayed as boxes.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1676230/+subscriptions


References