mahara-contributors team mailing list archive

[Mahara Bot <1689923@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/7749
Committed: https://git.mahara.org/mahara/mahara/commit/65d77bc01fb130f8f1be05f4582aeaba70c5d058
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    17.04_STABLE

commit 65d77bc01fb130f8f1be05f4582aeaba70c5d058
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Thu May 11 14:17:51 2017 +1200

Bug 1689923: Not using the default presubmitcallback

That turn the submit button into 'Processing...'

Instead we'll ignore the presubmit option altogether

behatnotneeded

Change-Id: Iccd4cac7fcc5e2161bedf2e5f37e4466f837f504
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit ebde3f5a4bcfeb0a5d87ac4714c05760a67e6535)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1689923

Title:
  Problems adding annotation comments to SmartEvidence in 17.04 via
  matrix page

Status in Mahara:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed

Bug description:
  When adding a comment to a point on the matrix on submission of
  comment the button changes from 'Place feedback' to 'Processing...'
  but doesn't change back.

  I believe this is due to the jQuery changes made recently

  Normally we  submit via pieform and replace the form on success but in
  this case we submit via ajax.

  So we need to add some js to turn the 'Processing...' back to 'Place
  feedback' on return of success or error.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1689923/+subscriptions